Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed onMouseDown handler to avoid double submission #459

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Removed onMouseDown handler to avoid double submission #459

merged 1 commit into from
Oct 31, 2023

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Oct 31, 2023

Fixes #458

@3coins 3coins added the bug Something isn't working label Oct 31, 2023
@3coins 3coins marked this pull request as ready for review October 31, 2023 19:05
@3coins
Copy link
Collaborator Author

3coins commented Oct 31, 2023

@JasonWeill @andrii-i
Can you please verify the fix on your machines.

@3coins 3coins changed the title Removed onMouseDown handler to avoid double submission. Removed onMouseDown handler to avoid double submission Oct 31, 2023
JasonWeill
JasonWeill approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Safari, Chrome, and Firefox, including Chrome in touch screen mode

@3coins 3coins merged commit e4986ce into jupyter-server:main Oct 31, 2023
6 checks passed
3coins added a commit to 3coins/jupyter-scheduler that referenced this pull request Oct 31, 2023
@3coins
Removed onMouseDown handler to avoid double submission. (jupyter-serv…
86e4db7 
…er#459)
@3coins 3coins mentioned this pull request Oct 31, 2023
Merged
3coins added a commit that referenced this pull request Oct 31, 2023
@3coins
Removed onMouseDown handler to avoid double submission. (#459)
9600bfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonWeill JasonWeill JasonWeill approved these changes

@andrii-i andrii-i Awaiting requested review from andrii-i

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete job button is calling the delete API twice
2 participants
@3coins @JasonWeill